linux-kernel - Re: [PATCH] staging: lustre: mgc: make llog_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <57EFF4DF-FEA7-40D5-AD29-4DF3E16D047B@intel.com>
Date:   Mon, 5 Dec 2016 17:48:11 -0500
From:   Oleg Drokin <oleg.drokin@...el.com>
To:     "<sandeepjain.linux@...il.com>" <sandeepjain.linux@...il.com>
Cc:     <andreas.dilger@...el.com>, <jsimmons@...radead.org>,
        <gregkh@...uxfoundation.org>, <lustre-devel@...ts.lustre.org>,
        <devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: lustre: mgc: make llog_process_lock static


On Dec 4, 2016, at 9:21 PM, <sandeepjain.linux@...il.com> <sandeepjain.linux@...il.com> wrote:

> From: Sandeep Jain <sandeepjain.linux@...il.com>
> 
> Fix following sparse warning.
> mgc_request.c:376:1:
> warning: symbol 'llog_process_lock' was not declared. Should it be static?
> 
> Signed-off-by: Sandeep Jain <sandeepjain.linux@...il.com>

Acked-by: Oleg Drokin <oleg.drokin@...el.com>

> ---
> drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
> index 23600fb..e98a2ce 100644
> --- a/drivers/staging/lustre/lustre/mgc/mgc_request.c
> +++ b/drivers/staging/lustre/lustre/mgc/mgc_request.c
> @@ -373,7 +373,7 @@ static int config_log_add(struct obd_device *obd, char *logname,
> 	return rc;
> }
> 
> -DEFINE_MUTEX(llog_process_lock);
> +static DEFINE_MUTEX(llog_process_lock);
> 
> /** Stop watching for updates on this log.
>  */
> -- 
> 2.7.4