linux-kernel - Re: [PATCH 1/1] vfio iommu type1: WARN_ON if notifier block is not unregistered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161205162613.693a7c52@t450s.home>
Date:   Mon, 5 Dec 2016 16:26:13 -0700
From:   Alex Williamson <alex.williamson@...hat.com>
To:     Kirti Wankhede <kwankhede@...dia.com>
Cc:     <pbonzini@...hat.com>, <kraxel@...hat.com>, <cjia@...dia.com>,
        <qemu-devel@...gnu.org>, <kvm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] vfio iommu type1: WARN_ON if notifier block is not
 unregistered

On Tue, 6 Dec 2016 02:38:20 +0530
Kirti Wankhede <kwankhede@...dia.com> wrote:

> mdev vendor driver should unregister the iommu notifier since the vfio
> iommu can persist beyond the attachment of the mdev group. WARN_ON will
> show warning if vendor driver doesn't unregister the notifier and is
> forced to follow the implementations steps.
> 
> Signed-off-by: Kirti Wankhede <kwankhede@...dia.com>
> Signed-off-by: Neo Jia <cjia@...dia.com>
> Change-Id: I75fd0a40e582a144fe7a037c7140d3513e8ff030
> ---
>  drivers/vfio/vfio_iommu_type1.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
> index 023fba7b8d5a..37871ee0c0c5 100644
> --- a/drivers/vfio/vfio_iommu_type1.c
> +++ b/drivers/vfio/vfio_iommu_type1.c
> @@ -1361,6 +1361,8 @@ static void vfio_sanity_check_pfn_list(struct vfio_iommu *iommu)
>  		if (WARN_ON(!RB_EMPTY_ROOT(&dma->pfn_list)))
>  			break;
>  	}
> +	/* mdev venfor driver must unregister notifier */

s/venfor/vendor/

> +	WARN_ON(iommu->notifier.head);
>  }
>  
>  static void vfio_iommu_type1_detach_group(void *iommu_data,

Applied for v4.10 with the above typo fix.  Thanks,

Alex