linux-kernel - Re: [PATCH v2] perf sched timehist: Improve error message when analyzing wrong file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b7e62e2-ef1d-6ad1-86c7-16c32c83a94f@gmail.com>
Date:   Mon, 5 Dec 2016 15:41:54 -0800
From:   David Ahern <dsahern@...il.com>
To:     Namhyung Kim <namhyung@...nel.org>, acme@...nel.org
Cc:     mingo@...nel.org, peterz@...radead.org, jolsa@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] perf sched timehist: Improve error message when
 analyzing wrong file

On 11/29/16 9:31 PM, Namhyung Kim wrote:
> On 11/30/16, David Ahern <dsahern@...il.com> wrote:
>> Arnaldo reported an unhelpful error message when running perf sched
>> timehist on a file that did not contain sched tracepoints:
>>
>>     [root@...et ~]# perf sched timehist
>>     No trace sample to read. Did you call 'perf record -R'?
>>
>>     [root@...et ~]# perf evlist -v
>>     cycles:ppp: size: 112, { sample_period, sample_freq }: 4000,
>> sample_type: IP|TID|TIME|CALLCHAIN|CPU|PERIOD, disabled: 1, inherit: 1,
>> mmap: 1, comm: 1, freq: 1, task: 1, precise_ip: 3, sample_id_all: 1,
>> exclude_guest: 1, mmap2: 1, comm_exec: 1
>>
>> Change the has_traces check to look for the sched_switch event. Analysis
>> for perf sched timehist requires at least this event.
>>
>> Now when analyzing a file without sched tracepoints you get:
>>
>>     root@...-vbox:/tmp$ perf sched timehist
>>     No sched_switch events found. Have you run 'perf sched record'?
>>
>> Signed-off-by: David Ahern <dsahern@...il.com>
> 
> Acked-by: Namhyung Kim <namhyung@...nel.org>
> 
> Thanks,
> Namhyung
> 

Arnaldo: I think this one has been overlooked