linux-kernel - Re: [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h4m2h5y68.wl-tiwai@suse.de>
Date:   Tue, 06 Dec 2016 08:11:59 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Shuah Khan" <shuahkh@....samsung.com>
Cc:     <mchehab@...nel.org>, <geliangtang@....com>,
        <alsa-devel@...a-project.org>, <hans.verkuil@...co.com>,
        <chehabrafael@...il.com>, <mahasler@...il.com>,
        <g.liakhovetski@....de>, <laurent.pinchart@...asonboard.com>,
        <sakari.ailus@....fi>, <clemens@...isch.de>, <k@...w.org>,
        <javier@....samsung.com>, <perex@...ex.cz>, <vdronov@...hat.com>,
        "Oliver Neukum" <ONeukum@...e.com>, <linux-kernel@...r.kernel.org>,
        <linux-media@...r.kernel.org>, <daniel@...que.org>
Subject: Re: [PATCH v6 3/3] sound/usb: Use Media Controller API to share media resources

On Mon, 05 Dec 2016 23:44:30 +0100,
Shuah Khan wrote:
> 
> On 11/30/2016 03:01 PM, Shuah Khan wrote:
> > Change ALSA driver to use Media Controller API to share media resources
> > with DVB, and V4L2 drivers on a AU0828 media device.
> > 
> > Media Controller specific initialization is done after sound card is
> > registered. ALSA creates Media interface and entity function graph
> > nodes for Control, Mixer, PCM Playback, and PCM Capture devices.
> > 
> > snd_usb_hw_params() will call Media Controller enable source handler
> > interface to request the media resource. If resource request is granted,
> > it will release it from snd_usb_hw_free(). If resource is busy, -EBUSY is
> > returned.
> > 
> > Media specific cleanup is done in usb_audio_disconnect().
> > 
> > Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> 
> Hi Takashi,
> 
> If you are good with this patch, could you please Ack it, so Mauro
> can pull it into media tree with the other two patches in this series,
> when he is ready to do so.

Sorry for the late review.

The biggest concern right now is the way the driver is probed.  As
mentioned in the review reply, we need to consider the cases where the
probe is called multiple times.  Other things are minor.


thanks,

Takashi