linux-kernel - Re: [PATCH]net:witchdev:release the lock before function return to avoid dead lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20161206080655.GC1984@nanopsycho>
Date:   Tue, 6 Dec 2016 09:06:55 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Feng Deng <cxdx2006@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, feng.deng@...tina-access.com
Subject: Re: [PATCH]net:witchdev:release the lock before function return to
 avoid dead lock

Tue, Dec 06, 2016 at 03:58:29AM CET, cxdx2006@...il.com wrote:
>>From : Feng Deng <cxdx2006@...il.com>
>
>In switchdev_deferred_dequeue(),only get the lock at the beginning,
>but forgot to release before return,
>we must release the lock to avoid dead lock
 
Feng, your patches are corrupted. Please use "git send-email"
Also, when you send a fit for -net tree, you have to pass byt the
"Fixes" tag. Please see the git log for details.

Thanks!


>
>Signed-off-by: Feng Deng <feng.deng@...tina-access.com>
>---
> net/switchdev/switchdev.c | 1 +
> 1 file changed, 1 insertion(+)
> mode change 100644 => 100755 net/switchdev/switchdev.c
>
>diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
>index 3b95fe9..c0a1ad4
>--- a/net/switchdev/switchdev.c
>+++ b/net/switchdev/switchdev.c
>@@ -120,6 +120,7 @@ static struct switchdev_deferred_item
>*switchdev_deferred_dequeue(void)
>  dfitem = list_first_entry(&deferred,
>   struct switchdev_deferred_item, list);
>  list_del(&dfitem->list);
>+ spin_unlock_bh(&deferred_lock);
> unlock:
>  spin_unlock_bh(&deferred_lock);
>  return dfitem;
>-- 
>1.8.3.1