linux-kernel - Re: [PATCH 5/7] perf tools: Force fixdep compilation at the start of the build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161206104757.GA22902@krava>
Date:   Tue, 6 Dec 2016 11:47:57 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Namhyung Kim <namhyung@...nel.org>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 5/7] perf tools: Force fixdep compilation at the start of
 the build

On Mon, Dec 05, 2016 at 05:02:51PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, Dec 04, 2016 at 09:42:56PM +0100, Jiri Olsa escreveu:
> > The fixdep tool needs to be built before everything else,
> > because it fixes every object dependency file.
> > 
> > We handle this currently by making all objects to depend
> > on fixdep, which is error prone and is easily forgotten
> > when new object is added.
> > 
> > Instead of this, this patch force fixdep tool to be built
> > as the first target in the separate make session. This way
> > we don't need to handle extra fixdep dependencies and we are
> > certain there's no fixdep race with any parallel make job.
> 
> With your updated version I'm getting this:
> 
> $ make -k O=/tmp/build/perf -C tools/perf install-bin
> <BIG SNIP>
>   LINK     /tmp/build/perf/libperf-gtk.so
>   INSTALL  GTK UI
> install: cannot change permissions of ‘/lib64’: Operation not permitted
> install: cannot create regular file '/lib64/libperf-gtk.so': Permission denied
> Makefile.perf:738: recipe for target 'install-gtk' failed
> make[2]: *** [install-gtk] Error 1
> make[2]: *** Waiting for unfinished jobs....
> Makefile.perf:383: recipe for target 'sub-make' failed
> make[1]: *** [sub-make] Error 2
> Makefile:108: recipe for target 'install-bin' failed
> make: *** [install-bin] Error 2
> make: Leaving directory '/home/acme/git/linux/tools/perf'

hum, tests/make does not cover $HOME installation :-\

anyway, I needed to do more changes and I pushed them all
into my perf/fixes again and now I'm running all tests..

it also has the check-headers.sh fix we discussed

I'll post later today if the tests are ok

thanks,
jirka