linux-kernel - Re: [PATCH] block: fix unintended fallthrough in generic_make_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87eg1l53dl.fsf@gmail.com>
Date:   Tue, 06 Dec 2016 01:04:54 +0100
From:   Nicolai Stange <nicstange@...il.com>
To:     Nicolai Stange <nicstange@...il.com>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Jens Axboe <axboe@...nel.dk>,
        Chaitanya Kulkarni <chaitanya.kulkarni@...t.com>,
        Shaun Tancheff <shaun.tancheff@...gate.com>,
        Damien Le Moal <damien.lemoal@...t.com>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: fix unintended fallthrough in generic_make_request_checks()

Nicolai Stange <nicstange@...il.com> writes:

> ---
> Applicable to next-20161202.
>
> Note that after this patch, I'm seeing a single
>  EXT4-fs (dm-1): Delayed block allocation failed for inode 2625094 at
>                  logical offset 2032 with max blocks 2 with error 121
> with 121 == EREMOTEIO
>
> This is because my SATA sda reports 0x20 (invalid command) back
> in response to 0x41 (WRITE_SAME).
>
> After this has happened, sd_done() disables "write same" once and for
> all, hence only this single message.
>
> I expect this to get fixed by
>   https://patchwork.kernel.org/patch/9321963/

Just FYI: Not really, the (supposedly) corresponding commit has already
been in linux-next when I was testing: commit 0ce1b18c42a5 ("libata:
Some drives failing on SCT Write Same").

I sent separate patch for this issue:
http://lkml.kernel.org/r/20161205235638.11539-1-nicstange@gmail.com

Regards,

Nicolai