linux-kernel - Re: [PATCH] device-dax: fail all private mapping attempts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.11.1612051648270.1536@eggly.anvils>
Date:   Mon, 5 Dec 2016 17:01:58 -0800 (PST)
From:   Hugh Dickins <hughd@...gle.com>
To:     Dan Williams <dan.j.williams@...el.com>
cc:     linux-nvdimm@...ts.01.org, linux-mm@...ck.org,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Pawel Lebioda <pawel.lebioda@...el.com>
Subject: Re: [PATCH] device-dax: fail all private mapping attempts

On Wed, 16 Nov 2016, Dan Williams wrote:

> The device-dax implementation originally tried to be tricky and allow
> private read-only mappings, but in the process allowed writable
> MAP_PRIVATE + MAP_NORESERVE mappings.  For simplicity and predictability
> just fail all private mapping attempts since device-dax memory is
> statically allocated and will never support overcommit.
> 
> Cc: <stable@...r.kernel.org>
> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> Fixes: dee410792419 ("/dev/dax, core: file operations and dax-mmap")
> Reported-by: Pawel Lebioda <pawel.lebioda@...el.com>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
> ---
>  drivers/dax/dax.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c
> index 0e499bfca41c..3d94ff20fdca 100644
> --- a/drivers/dax/dax.c
> +++ b/drivers/dax/dax.c
> @@ -270,8 +270,8 @@ static int check_vma(struct dax_dev *dax_dev, struct vm_area_struct *vma,
>  	if (!dax_dev->alive)
>  		return -ENXIO;
>  
> -	/* prevent private / writable mappings from being established */
> -	if ((vma->vm_flags & (VM_NORESERVE|VM_SHARED|VM_WRITE)) == VM_WRITE) {
> +	/* prevent private mappings from being established */
> +	if ((vma->vm_flags & VM_SHARED) != VM_SHARED) {

I think that is more restrictive than you intended: haven't tried,
but I believe it rejects a PROT_READ, MAP_SHARED, O_RDONLY fd mmap,
leaving no way to mmap /dev/dax without write permission to it.

See line 1393 of mm/mmap.c: the test you want is probably
	if (!(vma->vm_flags & VM_MAYSHARE))

Hugh

>  		dev_info(dev, "%s: %s: fail, attempted private mapping\n",
>  				current->comm, func);
>  		return -EINVAL;
> 
> --