linux-kernel - Re: [PATCH] xen/pci: Bubble up error and fix description.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Dec 2016 15:34:37 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Konrad Rzeszutek Wilk <konrad@...nel.org>,
        linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org,
        boris.ostrovsky@...cle.com, bhelgaas@...gle.com, x86@...nel.org,
        linux-pci@...r.kernel.org
Cc:     Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Subject: Re: [PATCH] xen/pci: Bubble up error and fix description.

On 06/12/16 15:28, Konrad Rzeszutek Wilk wrote:
> The function is never called under PV guests, and only shows up
> when MSI (or MSI-X) cannot be allocated. Convert the message
> to include the error value.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>

Reviewed-by: Juergen Gross <jgross@...e.com>

> ---
>  arch/x86/pci/xen.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
> index bedfab9..e1fb269 100644
> --- a/arch/x86/pci/xen.c
> +++ b/arch/x86/pci/xen.c
> @@ -264,8 +264,8 @@ static int xen_hvm_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
>  	return 0;
>  
>  error:
> -	dev_err(&dev->dev,
> -		"Xen PCI frontend has not registered MSI/MSI-X support!\n");
> +	dev_err(&dev->dev, "Failed to create MSI%s! ret=%d!\n",
> +		type == PCI_CAP_ID_MSI ? "" : "-X", irq);
>  	return irq;
>  }
>  
>