linux-kernel - Re: [PATCH] uapi glibc compat: fix outer guard of net device flags enum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161206.104400.2131603846152593015.davem@davemloft.net>
Date:   Tue, 06 Dec 2016 10:44:00 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     mikko.rapeli@....fi
Cc:     jonas.gorski@...il.com, linux-kernel@...r.kernel.org,
        zhangshengju@...s.chinamobile.com
Subject: Re: [PATCH] uapi glibc compat: fix outer guard of net device flags
 enum

From: Mikko Rapeli <mikko.rapeli@....fi>
Date: Mon, 5 Dec 2016 19:34:02 +0200

> On Sat, Dec 03, 2016 at 05:31:45PM +0100, Jonas Gorski wrote:
>> Fix a wrong condition preventing the higher net device flags
>> IFF_LOWER_UP etc to be defined if net/if.h is included before
>> linux/if.h.
>> 
>> The comment makes it clear the intention was to allow partial
>> definition with either parts.
>> 
>> This fixes compilation of userspace programs trying to use
>> IFF_LOWER_UP, IFF_DORMANT or IFF_ECHO.
>> 
>> Fixes: 4a91cb61bb99 ("uapi glibc compat: fix compile errors when glibc net/if.h included before linux/if.h")
>> Signed-off-by: Jonas Gorski <jonas.gorski@...il.com>
> 
> Reviewed-by: Mikko Rapeli <mikko.rapeli@....fi>
> 
> Yep, sorry about the logic error. Thanks for the fix!

Applied.

Jonas, please properly put netdev@...r.kernel.org on the CC: for networking
patches in the future.

Thank you.