linux-kernel - Re: [PATCH] perf tools: Explicitly document that --children is enabled by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Dec 2016 16:45:42 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Yannick Brosseau <scientist@...com>
Cc:     mingo@...hat.com, peterz@...radead.org, namhyung@...nel.org,
        linux-kernel@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH] perf tools: Explicitly document that --children is
 enabled by default

Em Fri, Dec 02, 2016 at 11:07:32AM -0500, Yannick Brosseau escreveu:
> The fact that the --children option is enabled by default is buried deep
> at the end of the help page, in the overhead calculation section. This
> make it explicit right where the option is listed, following the same
> way other default options are described

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Yannick Brosseau <scientist@...com>
> ---
>  tools/perf/Documentation/perf-report.txt | 3 ++-
>  tools/perf/Documentation/perf-top.txt    | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
> index 2d17462..aaa8011 100644
> --- a/tools/perf/Documentation/perf-report.txt
> +++ b/tools/perf/Documentation/perf-report.txt
> @@ -239,7 +239,8 @@ OPTIONS
>  	Accumulate callchain of children to parent entry so that then can
>  	show up in the output.  The output will have a new "Children" column
>  	and will be sorted on the data.  It requires callchains are recorded.
> -	See the `overhead calculation' section for more details.
> +	See the `overhead calculation' section for more details. Enabled by
> +	default, disable with --no-children.
>  
>  --max-stack::
>  	Set the stack depth limit when parsing the callchain, anything
> diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt
> index 91d638d..e71d638 100644
> --- a/tools/perf/Documentation/perf-top.txt
> +++ b/tools/perf/Documentation/perf-top.txt
> @@ -170,6 +170,7 @@ Default is to monitor all CPUS.
>  	show up in the output.  The output will have a new "Children" column
>  	and will be sorted on the data.  It requires -g/--call-graph option
>  	enabled.  See the `overhead calculation' section for more details.
> +	Enabled by default, disable with --no-children.
>  
>  --max-stack::
>  	Set the stack depth limit when parsing the callchain, anything
> -- 
> 2.10.2