linux-kernel - Re: Oops with CONFIG_VMAP_STCK and bond device + virtio-net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpXDHuJDXtBU=-sLZuo2O9HeVnWTOFeuHdf0s29zBFMTGw@mail.gmail.com>
Date:   Tue, 6 Dec 2016 21:58:56 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Laura Abbott <labbott@...hat.com>
Cc:     "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Zbigniew Jędrzejewski-Szmek <zbyszek@...waw.pl>,
        virtualization@...ts.linux-foundation.org,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Oops with CONFIG_VMAP_STCK and bond device + virtio-net

On Mon, Dec 5, 2016 at 3:53 PM, Laura Abbott <labbott@...hat.com> wrote:
> This looks like an issue with CONFIG_VMAP_STACK since bond_enslave uses
> struct sockaddr from the stack and virtnet_set_mac_address calls
> sg_init_one which triggers BUG_ON(!virt_addr_valid(buf));
>
> I know there have been a lot of CONFIG_VMAP_STACK fixes around but I
> didn't find this one reported yet.

Fixed by:

commit e37e2ff350a321ad9c36b588e76f34fbba305be6
Author: Andy Lutomirski <luto@...nel.org>
Date:   Mon Dec 5 18:10:58 2016 -0800

    virtio-net: Fix DMA-from-the-stack in virtnet_set_mac_address()