linux-kernel - Re: [PATCH] pinctrl: meson: fix gpio request disabling other modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2bmwoftua.fsf@baylibre.com>
Date:   Tue, 06 Dec 2016 16:47:41 -0800
From:   Kevin Hilman <khilman@...libre.com>
To:     Neil Armstrong <narmstrong@...libre.com>
Cc:     linus.walleij@...aro.org, carlo@...one.org,
        linux-gpio@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Beniamino Galvani <b.galvani@...il.com>
Subject: Re: [PATCH] pinctrl: meson: fix gpio request disabling other modes

Neil Armstrong <narmstrong@...libre.com> writes:

> The pinctrl_gpio_request is called with the "full" gpio number, already
> containing the base, then meson_pmx_request_gpio is then called with the
> final pin number.
> Remove the base addition when calling meson_pmx_disable_other_groups.
>
> Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs")
> CC: Beniamino Galvani <b.galvani@...il.com>
> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>

Acked-by: Kevin Hilman <khilman@...libre.com>