linux-kernel - Re: [PATCH] tracing/rb: init the CPU mask on allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201612072333.HCI81230.OOFQHJtOVFSFLM@I-love.SAKURA.ne.jp>
Date:   Wed, 7 Dec 2016 23:33:34 +0900
From:   Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
To:     bigeasy@...utronix.de
Cc:     tglx@...utronix.de, hpa@...or.com, mingo@...nel.org,
        linux-kernel@...r.kernel.org, rostedt@...dmis.org
Subject: Re: [PATCH] tracing/rb: init the CPU mask on allocation

Sebastian Andrzej Siewior wrote:
> Before commit b32614c03413 ("tracing/rb: Convert to hotplug state
> machine") the allocated cpumask was initialized to the mask of ONLINE or
> POSSIBLE CPUs. After the CPU hotplug changes the buffer initialisation
> moved to trace_rb_cpu_prepare() but I forgot to initially set the
> cpumask to zero. This is done now.
> 
> Fixes: b32614c03413 ("tracing/rb: Convert to hotplug state machine")
> Reported-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

The system can boot now. Thank you.

Tested-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>

> ---
>  kernel/trace/ring_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> index 67da107e5712..a85739efcc30 100644
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -1297,7 +1297,7 @@ struct ring_buffer *__ring_buffer_alloc(unsigned long size, unsigned flags,
>  	if (!buffer)
>  		return NULL;
>  
> -	if (!alloc_cpumask_var(&buffer->cpumask, GFP_KERNEL))
> +	if (!zalloc_cpumask_var(&buffer->cpumask, GFP_KERNEL))
>  		goto fail_free_buffer;
>  
>  	nr_pages = DIV_ROUND_UP(size, BUF_PAGE_SIZE);
> -- 
> 2.11.0