linux-kernel - Re: [PATCH] gpio/gpiolib.c:Fixing style issues in gpiolib.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZeytQDraQHjp_EB-Og-9RY7pEdzw+0vi5k_UO9Jw7t=g@mail.gmail.com>
Date:   Wed, 7 Dec 2016 16:07:43 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Mukesh Kaushik <mukesh.k4@...sung.com>
Cc:     Alexandre Courbot <gnurou@...il.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        vidushi.koul@...sung.com
Subject: Re: [PATCH] gpio/gpiolib.c:Fixing style issues in gpiolib.c

On Mon, Dec 5, 2016 at 12:45 PM, Mukesh Kaushik <mukesh.k4@...sung.com> wrote:

> Fixing the following checkpatch.pl error:
>
> ERROR: else should follow close brace '}'
> +       }
> +       else if (test_bit(FLAG_OPEN_SOURCE, &desc->flags)) {
>
> ERROR: space prohibited after that open parenthesis '('
> +       if ( !desc->gdev->chip ) { \
>
> ERROR: space prohibited before that close parenthesis ')'
> +       if ( !desc->gdev->chip ) { \
>
> and following warnings :
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> WARNING: else is not generally useful after a break or return
> +                       break;
> +               else
>
> Change-Id: I9164832686efb8db1f6d365f89f278e998104f81

Gerrit? We don't need this.

> Signed-off-by: Mukesh Kaushik <mukesh.k4@...sung.com>

This does not apply to my devel branch.

Please rebase on devel or v4.9 final whatever comes first
and resend.

Yours,
Linus Walleij