linux-kernel - Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33d23121-e5ca-0e14-bfbb-632f883e0948@gmail.com>
Date:   Wed, 7 Dec 2016 16:20:06 +0100
From:   Quentin Lambert <lambert.quentin@...il.com>
To:     Oleg Drokin <oleg.drokin@...el.com>
Cc:     Andreas Dilger <andreas.dilger@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due
 to an assignment from kernel to user space

Hi all,

I am looking at the drivers/staging/lustre/lustre/llite/dir.c:

1469                 /* Call mdc_iocontrol */
1470                 rc = obd_iocontrol(LL_IOC_FID2MDTIDX, exp, 
sizeof(fid), &fid,
1471                                    &index);
1472                 if (rc)

and sparse says:

drivers/staging/lustre/lustre/llite/dir.c:1471:37: warning: incorrect 
type in argument 5 (different address spaces)

I was wondering if there was any value to add a cast to fix the warning?
And I guess this solution would also apply in my original patch to

drivers/staging/lustre/lnet/lnet/lib-socket.c

Quentin