linux-kernel - Re: [PATCH 1/1 linux-next] ASoC: samsung: include gpio consumer.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161207175502.GA13187@kozik-lap>
Date:   Wed, 7 Dec 2016 19:55:02 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Fabian Frederick <fabf@...net.be>
Cc:     Krzysztof Kozlowski <krzk@...nel.org>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1 linux-next] ASoC: samsung: include gpio consumer.h

On Wed, Dec 07, 2016 at 08:39:02AM +0100, Fabian Frederick wrote:
> Fix the following build errors

I couldn't reproduce it on default config. Can you mention the necessary
environment/defconfig/arch etc.?

Patch itself looks needed. However shouldn't the driver depend also on
GPIOLIB?

Best regards,
Krzysztof

> sound/soc/samsung/tm2_wm5110.c:220:3: error: implicit declaration
> of function 'gpiod_set_value_cansleep' [-Werror=implicit-function-declaration]
> sound/soc/samsung/tm2_wm5110.c:438:24: error: implicit declaration
> of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  sound/soc/samsung/tm2_wm5110.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c
> index 5cdf7d1..24cc9d6 100644
> --- a/sound/soc/samsung/tm2_wm5110.c
> +++ b/sound/soc/samsung/tm2_wm5110.c
> @@ -12,6 +12,7 @@
>  
>  #include <linux/clk.h>
>  #include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
>  #include <sound/pcm_params.h>
> -- 
> 2.7.4
>