linux-kernel - Re: [PATCH 16/18] arm64: ptrace: handle ptrace_request differently for aarch32 and ilp32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3703608.GKr1zzErMk@wuerfel>
Date:   Wed, 07 Dec 2016 21:40:13 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Catalin Marinas <catalin.marinas@....com>
Cc:     Yury Norov <ynorov@...iumnetworks.com>, linux-doc@...r.kernel.org,
        szabolcs.nagy@....com, heiko.carstens@...ibm.com,
        cmetcalf@...hip.com, philipp.tomsich@...obroma-systems.com,
        joseph@...esourcery.com, linux-arch@...r.kernel.org,
        zhouchengming1@...wei.com, Prasun.Kapoor@...iumnetworks.com,
        agraf@...e.de, geert@...ux-m68k.org, kilobyte@...band.pl,
        manuel.montezelo@...il.com, pinskia@...il.com,
        linyongting@...wei.com, klimov.linux@...il.com, broonie@...nel.org,
        bamvor.zhangjian@...wei.com,
        Bamvor Zhang Jian <bamvor.zhangjian@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, maxim.kuvyrkov@...aro.org,
        Nathan_Lynch@...tor.com, linux-kernel@...r.kernel.org,
        schwidefsky@...ibm.com, davem@...emloft.net,
        christoph.muellner@...obroma-systems.com
Subject: Re: [PATCH 16/18] arm64: ptrace: handle ptrace_request differently for aarch32 and ilp32

On Wednesday, December 7, 2016 4:59:13 PM CET Catalin Marinas wrote:
> On Tue, Dec 06, 2016 at 11:55:08AM +0530, Yury Norov wrote:
> > On Mon, Dec 05, 2016 at 04:34:23PM +0000, Catalin Marinas wrote:
> > > On Fri, Oct 21, 2016 at 11:33:15PM +0300, Yury Norov wrote:
> > > > New aarch32 ptrace syscall handler is introduced to avoid run-time
> > > > detection of the task type.
> > > 
> > > What's wrong with the run-time detection? If it's just to avoid a
> > > negligible overhead, I would rather keep the code simpler by avoiding
> > > duplicating the generic compat_sys_ptrace().
> > 
> > Nothing wrong. This is how Arnd asked me to do. You already asked this
> > question: http://lkml.iu.edu/hypermail/linux/kernel/1604.3/00930.html
> 
> Hmm, I completely forgot about this ;). There is still an advantage to
> doing run-time checking if we avoid touching core code (less acks to
> gather and less code duplication).
> 
> Let's see what Arnd says but the initial patch looked simpler.

I don't currently have either version of the patch in my inbox
(the archive is on a different machine), but in general I'd still
think it's best to avoid the runtime check for aarch64-ilp32
altogether. I'd have to look at the overall kernel source to
see if it's worth avoiding one or two instances though, or
if there are an overwhelming number of other checks that we
can't avoid at all.

Regarding ptrace, I notice that arch/tile doesn't even use
the compat entry point for its ilp32 user space on 64-bit
kernels, it just calls the regular 64-bit one. Would that
help here?

	Arnd