linux-kernel - Re: [PATCH] ARM: dts: imx7d: fix LCDIF clock assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161207205314.GA20203@localhost>
Date:   Wed, 7 Dec 2016 12:53:14 -0800
From:   Olof Johansson <olof@...om.net>
To:     Shawn Guo <shawnguo@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        Stefan Agner <stefan@...er.ch>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>, robh+dt@...nel.org,
        Peter Chen <peter.chen@...escale.com>,
        Fabio Estevam <fabio.estevam@....com>,
        Liu Ying <Ying.Liu@...escale.com>,
        linux-arm-kernel@...ts.infradead.org,
        Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH] ARM: dts: imx7d: fix LCDIF clock assignment

On Mon, Dec 05, 2016 at 10:01:24AM +0800, Shawn Guo wrote:
> Hi Arnd, Olof,
> 
> On Sun, Dec 04, 2016 at 05:26:58PM -0800, Stefan Agner wrote:
> > Hi Shawn
> > 
> > On 2016-11-23 15:02, Fabio Estevam wrote:
> > > On Tue, Nov 22, 2016 at 10:42 PM, Stefan Agner <stefan@...er.ch> wrote:
> > >> The eLCDIF IP of the i.MX 7 SoC knows multiple clocks and lists them
> > >> separately:
> > >>
> > >> Clock      Clock Root              Description
> > >> apb_clk    MAIN_AXI_CLK_ROOT       AXI clock
> > >> pix_clk    LCDIF_PIXEL_CLK_ROOT    Pixel clock
> > >> ipg_clk_s  MAIN_AXI_CLK_ROOT       Peripheral access clock
> > >>
> > >> All of them are switched by a single gate, which is part of the
> > >> IMX7D_LCDIF_PIXEL_ROOT_CLK clock. Hence using that clock also for
> > >> the AXI bus clock (clock-name "axi") makes sure the gate gets
> > >> enabled when accessing registers.
> > >>
> > >> There seem to be no separate AXI display clock, and the clock is
> > >> optional. Hence remove the dummy clock.
> > >>
> > >> This fixes kernel freezes when starting the X-Server (which
> > >> disables/re-enables the display controller).
> > >>
> > >> Signed-off-by: Stefan Agner <stefan@...er.ch>
> > > 
> > > Reviewed-by: Fabio Estevam <fabio.estevam@....com>
> > 
> > Since this fixes a kernel freeze, is there a chance to get this still in
> > 4.9?
> 
> Since we get one more week to the final 4.9, is it possible for you to
> send this fix for 4.9 inclusion?  Thanks.
> 
> For the patch,
> 
> Acked-by: Shawn Guo <shawnguo@...nel.org>

Applied, with the fixes line. In the future, please email arm@...nel.org too,
it's easier to make sure we don't miss it that way.


-Olof