linux-kernel - Re: [PATCH] n900 device tree: cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161207031048.pi7j4dms5uuco3yf@earth>
Date:   Wed, 7 Dec 2016 04:10:48 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Tony Lindgren <tony@...mide.com>, Pavel Machek <pavel@....cz>
Cc:     pali.rohar@...il.com, kernel list <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-omap@...r.kernel.org, tony@...mide.com, khilman@...nel.org,
        aaro.koskinen@....fi, ivo.g.dimitrov.75@...il.com,
        patrikbachan@...il.com, serge@...lyn.com, bcousson@...libre.com,
        robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] n900 device tree: cleanup

Hi Tony,

It looks like this fell through the cracks. Apart from inconsistent
patch subject:

Reviewed-By: Sebastian Reichel <sre@...nel.org>

-- Sebastian

On Tue, Oct 11, 2016 at 10:12:43AM +0200, Pavel Machek wrote:
> Fix GPIO comment to be consistent with rest of file and add comment what
> tpa6130 is.
> 
> Signed-off-by: Pavel Machek <pavel@....cz>
> 
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index bfffd6c..ca9fe8c 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -47,7 +47,7 @@
>  		compatible = "gpio-leds";
>  		heartbeat {
>  			label = "debug::sleep";
> -			gpios = <&gpio6 2 GPIO_ACTIVE_HIGH>;  /* gpio162 */
> +			gpios = <&gpio6 2 GPIO_ACTIVE_HIGH>;  /* 162 */
>  			linux,default-trigger = "default-on";
>  			pinctrl-names = "default";
>  			pinctrl-0 = <&debug_leds>;
> @@ -637,6 +637,7 @@
>  		reg = <0x55>;
>  	};
>  
> +	/* Stereo headphone amplifier */
>  	tpa6130a2: tpa6130a2@60 {
>  		compatible = "ti,tpa6130a2";
>  		reg = <0x60>;

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)