linux-kernel - Re: [PATCH 1/1 v2] xen: set error code on failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f25ef6bd-df0f-8407-fb91-03886d799e4e@suse.com>
Date:   Thu, 8 Dec 2016 07:57:32 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Pan Bian <bianpan2016@....com>,
        David Vrabel <david.vrabel@...rix.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        xen-devel@...ts.xenproject.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1 v2] xen: set error code on failures

On 05/12/16 09:23, Pan Bian wrote:
> Variable rc is reset in the loop, and its value will be non-negative
> during the second and after repeat of the loop. If it fails to allocate
> memory then, it may return a non-negative integer, which indicates no
> error. This patch fixes the bug, assigning "-ENOMEM" to rc when
> kzalloc() or alloc_page() returns NULL, and removing the initialization
> of rc outside of the loop.
> 
> v1 is reviewed by: Juergen Gross <jgross@...e.com>
> 
> Signed-off-by: Pan Bian <bianpan2016@....com>

Commited to xen/tip.git for-linus-4.10


Juergen