lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 Dec 2016 16:43:13 +0100 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: Ian Abbott <abbotti@....co.uk> Cc: devel@...verdev.osuosl.org, Chris Cesare <chris.cesare@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, H Hartley Sweeten <hsweeten@...ionengravers.com>, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: Re: staging: comedi: usbdux: Split a condition check in usbdux_alloc_usb_buffers() > Actually, the original code worked fine, I got my doubts when some memory allocations are attempted without checking the desired success immediately. > and these changes will result in an Oops if the allocations fail. I'll explain why, > since it isn't obvious without some knowledge of the clean-up strategy used by comedi drivers: Thanks for your explanation. > …, and all the other comedi drivers follow the same strategy of leaving clean-up > to their comedi 'detach' handler. Are there other source code parts worth for further considerations? Regards, Markus
Powered by blists - more mailing lists