linux-kernel - Re: [Qemu-devel] [QEMU, PATCH] x86: implement la57 paging mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Dec 2016 08:48:11 -0800 (PST)
From:   no-reply@...chew.org
To:     kirill.shutemov@...ux.intel.com
Cc:     famz@...hat.com, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, x86@...nel.org, tglx@...utronix.de,
        mingo@...hat.com, arnd@...db.de, hpa@...or.com,
        linux-arch@...r.kernel.org, ak@...ux.intel.com, linux-mm@...ck.org,
        qemu-devel@...gnu.org, linux-kernel@...r.kernel.org,
        luto@...capital.net, dave.hansen@...el.com,
        kirill.shutemov@...ux.intel.com
Subject: Re: [Qemu-devel] [QEMU, PATCH] x86: implement la57 paging mode

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [QEMU, PATCH] x86: implement la57 paging mode
Type: series
Message-id: 20161208162150.148763-2-kirill.shutemov@...ux.intel.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
509e387 x86: implement la57 paging mode

=== OUTPUT BEGIN ===
Checking PATCH 1/1: x86: implement la57 paging mode...
ERROR: space prohibited before that close parenthesis ')'
#311: FILE: target-i386/monitor.c:108:
+                        print_pte(mon, env, (l1 << 30 ) + (l2 << 21), pde,

ERROR: space prohibited before that close parenthesis ')'
#320: FILE: target-i386/monitor.c:116:
+                                print_pte(mon, env, (l1 << 30 ) + (l2 << 21)

WARNING: line over 80 characters
#347: FILE: target-i386/monitor.c:148:
+                        print_pte(mon, env, (l0 << 48) + (l1 << 39) + (l2 << 30),

WARNING: line over 80 characters
#359: FILE: target-i386/monitor.c:158:
+                                    print_pte(mon, env, (l0 << 48) + (l1 << 39) +

WARNING: line over 80 characters
#467: FILE: target-i386/monitor.c:464:
+                                    cpu_physical_memory_read(pd_addr + l3 * 8, &pde, 8);

ERROR: line over 90 characters
#469: FILE: target-i386/monitor.c:466:
+                                    end = (l0 << 48) + (l1 << 39) + (l2 << 30) + (l3 << 21);

WARNING: line over 80 characters
#472: FILE: target-i386/monitor.c:469:
+                                            prot = pde & (PG_USER_MASK | PG_RW_MASK |

WARNING: line over 80 characters
#475: FILE: target-i386/monitor.c:472:
+                                            mem_print(mon, &start, &last_prot, end, prot);

WARNING: line over 80 characters
#480: FILE: target-i386/monitor.c:477:
+                                                                         + l4 * 8,

WARNING: line over 80 characters
#481: FILE: target-i386/monitor.c:478:
+                                                                         &pte, 8);

ERROR: line over 90 characters
#483: FILE: target-i386/monitor.c:480:
+                                                end = (l0 << 48) + (l1 << 39) + (l2 << 30) +

ERROR: line over 90 characters
#486: FILE: target-i386/monitor.c:483:
+                                                    prot = pte & (PG_USER_MASK | PG_RW_MASK |

WARNING: line over 80 characters
#487: FILE: target-i386/monitor.c:484:
+                                                                  PG_PRESENT_MASK);

ERROR: line over 90 characters
#492: FILE: target-i386/monitor.c:489:
+                                                mem_print(mon, &start, &last_prot, end, prot);

WARNING: line over 80 characters
#497: FILE: target-i386/monitor.c:494:
+                                        mem_print(mon, &start, &last_prot, end, prot);

total: 6 errors, 9 warnings, 481 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@...elists.org