linux-kernel - Re: [PATCH] memremap: Remove unused align

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPcyv4iUZL6d+L74OVfXu-1x4qZ-EedJOxuLGZbp6JRXV0KdWg@mail.gmail.com>
Date:   Thu, 8 Dec 2016 09:10:32 -0800
From:   Dan Williams <dan.j.williams@...el.com>
To:     Kirtika Ruchandani <kirtika@...omium.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] memremap: Remove unused align_* variables

On Wed, Dec 7, 2016 at 11:42 PM, Kirtika Ruchandani
<kirtika@...omium.org> wrote:
> Commit eb7d78c9e7f6 introduced align_start, align_size and align_end
> variables in pgmap_radix_release() but did not use them.
> Compiling with W=1 gives the following harmless warning, fix it to
> reduce the noise with W=1 in the kernel.
>
> kernel/memremap.c: In function ‘pgmap_radix_release’:
> kernel/memremap.c:199:48: warning: variable ‘align_end’ set but not used [-Wunused-but-set-variable]
>
> The call to resource_size has no side-effects and is safe to remove.
>
> Fixes: eb7d78c9e7f6 ("devm_memremap_pages: fix vmem_altmap lifetime + alignment handling")
> Cc: Dan Williams <dan.j.williams@...el.com>
> Signed-off-by: Kirtika Ruchandani <kirtika@...omium.org>

Thanks for the fix, however I'm already addressing this as a side effect of:

    https://lkml.org/lkml/2016/12/1/726

I'm in the process of posting v2 of that patch.