linux-kernel - Re: [PATCH V2 2/2] ASoC: samsung: add GPIOLIB dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Dec 2016 22:51:19 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Fabian Frederick <fabf@...net.be>
Cc:     Mark Brown <broonie@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 2/2] ASoC: samsung: add GPIOLIB dependency

On Thu, Dec 08, 2016 at 09:43:19PM +0100, Fabian Frederick wrote:
> Both SND_SOC_SMARTQ and SND_SOC_SAMSUNG_TM2_WM5110
> use gpio/consumer.h
> This patch adds GPIOLIB || COMPILE_TEST to Kconfig entries
> to avoid any build errors.

I think that is not entirely correct. There won't be build errors here
because build dependency is satisfied by header (for both cases: GPIOLIB
and !GPIOLIB). However this fixes runtime dependency - the driver
requires GPIOLIB to work.

Beside the commit msg, it is okay:
Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof

> 
> See commit 638f958baeaf
> ("extcon: Allow compile test of GPIO consumers if !GPIOLIB")
> 
> for similar problem and explanations.
> 
> Reported-by: Krzysztof Kozlowski <krzk@...nel.org>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  sound/soc/samsung/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
> index 7c42315..f1f1d79 100644
> --- a/sound/soc/samsung/Kconfig
> +++ b/sound/soc/samsung/Kconfig
> @@ -111,6 +111,7 @@ config SND_SOC_SAMSUNG_RX1950_UDA1380
>  config SND_SOC_SMARTQ
>  	tristate "SoC I2S Audio support for SmartQ board"
>  	depends on MACH_SMARTQ || COMPILE_TEST
> +	depends on GPIOLIB || COMPILE_TEST
>  	depends on I2C
>  	select SND_SAMSUNG_I2S
>  	select SND_SOC_WM8750
> @@ -193,6 +194,7 @@ config SND_SOC_ARNDALE_RT5631_ALC5631
>  config SND_SOC_SAMSUNG_TM2_WM5110
>  	tristate "SoC I2S Audio support for WM5110 on TM2 board"
>  	depends on SND_SOC_SAMSUNG && MFD_ARIZONA && I2C && SPI_MASTER
> +	depends on GPIOLIB || COMPILE_TEST
>  	select SND_SOC_MAX98504
>  	select SND_SOC_WM5110
>  	select SND_SAMSUNG_I2S
> -- 
> 2.7.4
>