linux-kernel - Re: [PATCH net-next 1/2] net: phy: add extension of phy-mode for XLGMII

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Dec 2016 14:15:39 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jie Deng <Jie.Deng1@...opsys.com>, davem@...emloft.net,
        netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, CARLOS.PALMINHA@...opsys.com,
        lars.persson@...s.com, thomas.lendacky@....com
Subject: Re: [PATCH net-next 1/2] net: phy: add extension of phy-mode for
 XLGMII

On 12/06/2016 07:57 PM, Jie Deng wrote:
> This patch adds phy-mode support for Synopsys XLGMAC

The functional changes look good, but I would like to see some
description of what the XL part stands for here.

While you are modifying this, do you also mind submitting a Device Tree
specification change:

https://www.devicetree.org/specifications/

Thanks!

> 
> Signed-off-by: Jie Deng <jiedeng@...opsys.com>
> ---
>  Documentation/devicetree/bindings/net/ethernet.txt | 1 +
>  include/linux/phy.h                                | 3 +++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/ethernet.txt b/Documentation/devicetree/bindings/net/ethernet.txt
> index 0515095..2378f00 100644
> --- a/Documentation/devicetree/bindings/net/ethernet.txt
> +++ b/Documentation/devicetree/bindings/net/ethernet.txt
> @@ -28,6 +28,7 @@ The following properties are common to the Ethernet controllers:
>    * "rtbi"
>    * "smii"
>    * "xgmii"
> +  * "xlgmii"
>    * "trgmii"
>  - phy-connection-type: the same as "phy-mode" property but described in ePAPR;
>  - phy-handle: phandle, specifies a reference to a node representing a PHY
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index feb8a98..b52f9f8 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -79,6 +79,7 @@
>  	PHY_INTERFACE_MODE_RTBI,
>  	PHY_INTERFACE_MODE_SMII,
>  	PHY_INTERFACE_MODE_XGMII,
> +	PHY_INTERFACE_MODE_XLGMII,
>  	PHY_INTERFACE_MODE_MOCA,
>  	PHY_INTERFACE_MODE_QSGMII,
>  	PHY_INTERFACE_MODE_TRGMII,
> @@ -136,6 +137,8 @@ static inline const char *phy_modes(phy_interface_t interface)
>  		return "smii";
>  	case PHY_INTERFACE_MODE_XGMII:
>  		return "xgmii";
> +	case PHY_INTERFACE_MODE_XLGMII:
> +		return "xlgmii";
>  	case PHY_INTERFACE_MODE_MOCA:
>  		return "moca";
>  	case PHY_INTERFACE_MODE_QSGMII:
> 


-- 
Florian