lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 9 Dec 2016 10:36:57 +0100
From:   Maxime Ripard <>
To:     Chen-Yu Tsai <>
Cc:     David Airlie <>,
        dri-devel <>,
        linux-arm-kernel <>,
        linux-kernel <>,
        linux-sunxi <>,
        Laurent Pinchart <>,
        Sean Paul <>,
        Eric Anholt <>,
        Daniel Vetter <>
Subject: Re: [PATCH RFC] drm/sun4i: rgb: Add 5% tolerance to dot clock
 frequency check

On Wed, Dec 07, 2016 at 10:26:25AM +0800, Chen-Yu Tsai wrote:
> > Some panels require an exact frequency, some have a minimal frequency
> > but no maximum, some have a maximum frequency but no minimal, and I
> > guess most of them deviates by how much exactly they can take (and
> > possibly can take more easily a higher frequency, but are less
> > tolerant if you take a frequency lower than the nominal.
> >
> > And we cannot remove that check entirely, since some bridges will
> > report out of range frequencies for higher modes that we know we
> > cannot reach.
> I believe this should be handled by the bridge driver in the check
> callback?

This doesn't really have anything to do with the bridge itself, it's a
limitation on the encoder. For all we know, the bridge might be able
to operate at the higher resolutions without any issues if the encoder
was able to.

> The callback I'm changing is attached to the connector, which I
> think doesn't get used if you have a bridge instead.  And this only
> checks the pre-registered display modes, such as those specified in
> simple-panel or EDID.

Geeee, I forgot to send that one (and thought I did)... I'll send that
patch next week, but basically, I was creating a mode_valid hook at
the encoder level, and moving the RGB mode_valid hook from the
connector to the encoder (since it really is an encoder limitation).


Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)

Powered by blists - more mailing lists