linux-kernel - Re: [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to volume_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h7f79mmg8.wl-tiwai@suse.de>
Date:   Fri, 09 Dec 2016 11:22:15 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Con Kolivas" <con@...ivas.org>
Cc:     <linux-kernel@...r.kernel.org>, <alsa-devel@...a-project.org>
Subject: Re: [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to  volume_control_quirks.

On Fri, 09 Dec 2016 05:15:57 +0100,
Con Kolivas wrote:
> 
> The Logitech QuickCam Communicate Deluxe/S7500 microphone fails with the
> following warning.
> 
> [    6.778995] usb 2-1.2.2.2: Warning! Unlikely big volume range (=3072),
> cval->res is probably wrong.
> [    6.778996] usb 2-1.2.2.2: [5] FU [Mic Capture Volume] ch = 1, val =
> 4608/7680/1
> 
> Adding it to the list of devices in volume_control_quirks makes it work
> properly, fixing related typo.
> 
> Signed-off-by: Con Kolivas <kernel@...ivas.org>

Applied (with Cc to stable), thanks.


Takashi

> 
> ---
>  sound/usb/mixer.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
> index 2f8c388..4703cae 100644
> --- a/sound/usb/mixer.c
> +++ b/sound/usb/mixer.c
> @@ -932,9 +932,10 @@ static void volume_control_quirks(struct usb_mixer_elem_info *cval,
>  	case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
>  	case USB_ID(0x046d, 0x08ca): /* Logitech Quickcam Fusion */
>  	case USB_ID(0x046d, 0x0991):
> +	case USB_ID(0x046d, 0x09a2): /* QuickCam Communicate Deluxe/S7500 */
>  	/* Most audio usb devices lie about volume resolution.
>  	 * Most Logitech webcams have res = 384.
> -	 * Proboly there is some logitech magic behind this number --fishor
> +	 * Probably there is some logitech magic behind this number --fishor
>  	 */
>  		if (!strcmp(kctl->id.name, "Mic Capture Volume")) {
>  			usb_audio_info(chip,
> -- 
> 2.7.4
> 
> 
>