linux-kernel - RE: ATH9 driver issues on ARM64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Dec 2016 11:04:00 +0000
From:   Bharat Kumar Gogada <bharat.kumar.gogada@...inx.com>
To:     Marc Zyngier <marc.zyngier@....com>,
        Bjorn Helgaas <helgaas@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "Janusz.Dziedzic@...to.com" <Janusz.Dziedzic@...to.com>,
        "rmanohar@....qualcomm.com" <rmanohar@....qualcomm.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "ath9k-devel@....qualcomm.com" <ath9k-devel@....qualcomm.com>
Subject: RE: ATH9 driver issues on ARM64

> On 09/12/16 02:07, Bharat Kumar Gogada wrote:
> >> On 08/12/16 18:33, Bharat Kumar Gogada wrote:
> >>>> On 08/12/16 15:29, Bharat Kumar Gogada wrote:
> >>>>> 218:         61          0          0          0     GICv2  81 Level     mmc0
> >>>>> 219:          0          0          0          0     GICv2 187 Level     arm-smmu global
> fault
> >>>>> 220:        471          0          0          0     GICv2  53 Level     xuartps
> >>>>> 223:          0          0          0          0     GICv2 154 Level     fd4c0000.dma
> >>>>> 224:          3          0          0          0     dummy   1 Edge      ath9k
> >>>>
> >>>> What is this "dummy" controller? And if that's supposed to be a
> >>>> legacy interrupt from the PCI device, it has the wrong trigger.
> >>>
> >>> Yes it is for legacy interrupt, wrong trigger means ?
> >>
> >> Aren't legacy interrupts supposed to be *level* triggered, and not edge?
> >>
> > Yes agreed.
> > For legacy interrupts im using irq_set_chained_handler_and_data so the
> > irq line between bridge and GIC Will not be shown here. The above how
> > is virq for legacy, which is given by kernel, not sure why its state is set to edge.
> 
> Well, you should try and find out. Edge triggering for legacy interrupts is a real
> bug, and I don't think it has anything to do with arm64 (despite what the subject
> says).
> 
Thanks Marc. Here is the ARM32 bit log for cat /proc/interrupts, 
Here also it shows edge but still scan works successfully.
root@:~#cat /proc/interrupts 
           CPU0       CPU1       
 16:          1          0     GIC-0  27 Edge      gt
 17:          0          0     GIC-0  43 Level     ttc_clockevent
 18:       3049       1170     GIC-0  29 Edge      twd
 21:         43          0     GIC-0  39 Level     f8007100.adc
141:        462          0     GIC-0  57 Level     cdns-i2c
143:          0          0     GIC-0  35 Level     f800c000.ocmc
144:       1259          0     GIC-0  82 Level     xuartps
145:          3          0     GIC-0  51 Level     e000d000.spi
146:          0          0     GIC-0  54 Level     eth0
147:         54          0     GIC-0  56 Level     mmc0
148:          0          0     GIC-0  45 Level     f8003000.dmac
149:          0          0     GIC-0  46 Level     f8003000.dmac
150:          0          0     GIC-0  47 Level     f8003000.dmac
151:          0          0     GIC-0  48 Level     f8003000.dmac
152:          0          0     GIC-0  49 Level     f8003000.dmac
153:          0          0     GIC-0  72 Level     f8003000.dmac
154:          0          0     GIC-0  73 Level     f8003000.dmac
155:          0          0     GIC-0  74 Level     f8003000.dmac
156:          0          0     GIC-0  75 Level     f8003000.dmac
157:          0          0     GIC-0  40 Level     f8007000.devcfg
163:          0          0     GIC-0  53 Level     e0002000.usb
164:          0          0     GIC-0  41 Edge      f8005000.watchdog
165:        158          0     GIC-0  61 Level     xilinx-pcie
166:        122         18     dummy   1 Edge      ath9k
IPI1:          0          0  Timer broadcast interrupts
IPI2:       1101       2349  Rescheduling interrupts
IPI3:         34         20  Function call interrupts
IPI4:          0          0  CPU stop interrupts
IPI5:          0          0  IRQ work interrupts
IPI6:          0          0  completion interrupts

root@...inx-ZC706-2016_3:~# iw dev wlnan0 scan
BSS d8:c7:c8:26:6a:72(on wlan0)
	TSF: 349496494967 usec (4d, 01:04:56)
	freq: 2412
	beacon interval: 100 TUs
	capability: ESS ShortPreamble ShortSlotTime (0x0421)
	signal: -47.00 dBm
	last seen: 2170 ms ago
.....
....

Thanks & Regards,
Bharat