linux-kernel - Re: [PATCH] firmware: dmi_scan: Always show system identification string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKv+Gu86rW34NozRHNNp13O0exoVL473kL8PFX-v114D8-u+_A@mail.gmail.com>
Date:   Fri, 9 Dec 2016 14:55:09 +0000
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:     Jean Delvare <jdelvare@...e.com>,
        Mark Rutland <mark.rutland@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] firmware: dmi_scan: Always show system identification string

On 9 December 2016 at 06:54, Kefeng Wang <wangkefeng.wang@...wei.com> wrote:
> Let's keep consistent when print dmi_ids_string between SMBIOS 2.x
> and SMBIOS 3.x, and always show the system identification string,
> like Vendor, Product/Board name and BIOS infos.
>

Are you saying the printk(KERN_DEBUG) was inconsistent with the
pr_debug() before?


> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> ---
>  drivers/firmware/dmi_scan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
> index 88bebe1..54be60e 100644
> --- a/drivers/firmware/dmi_scan.c
> +++ b/drivers/firmware/dmi_scan.c
> @@ -560,7 +560,7 @@ static int __init dmi_present(const u8 *buf)
>                                         dmi_ver >> 16, (dmi_ver >> 8) & 0xFF);
>                         }
>                         dmi_format_ids(dmi_ids_string, sizeof(dmi_ids_string));
> -                       printk(KERN_DEBUG "DMI: %s\n", dmi_ids_string);
> +                       pr_info("DMI: %s\n", dmi_ids_string);
>                         return 0;
>                 }
>         }
> @@ -588,7 +588,7 @@ static int __init dmi_smbios3_present(const u8 *buf)
>                                 dmi_ver >> 16, (dmi_ver >> 8) & 0xFF,
>                                 dmi_ver & 0xFF);
>                         dmi_format_ids(dmi_ids_string, sizeof(dmi_ids_string));
> -                       pr_debug("DMI: %s\n", dmi_ids_string);
> +                       pr_info("DMI: %s\n", dmi_ids_string);
>                         return 0;
>                 }
>         }
> --
> 1.7.12.4
>