linux-kernel - Re: [PATCH] remoteproc: qcom_adsp_pil: select qcom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3141429.Gm13CfGpJK@wuerfel>
Date:   Fri, 09 Dec 2016 21:42:55 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Ohad Ben-Cohen <ohad@...ery.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] remoteproc: qcom_adsp_pil: select qcom_scm

On Friday, December 9, 2016 11:23:10 AM CET Bjorn Andersson wrote:
> On Fri 09 Dec 03:47 PST 2016, Arnd Bergmann wrote:
> 
> > The adsp-pil driver relies on SCM and causes a build error without it:
> > 
> > ERROR: "qcom_scm_pas_supported" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
> > ERROR: "qcom_scm_is_available" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
> > ERROR: "qcom_scm_pas_auth_and_reset" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
> > ERROR: "qcom_scm_pas_shutdown" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
> > ERROR: "qcom_scm_pas_mem_setup" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
> > ERROR: "qcom_scm_pas_init_image" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
> > 
> > This adds a 'select', as SCM is a silent Kconfig symbol that gets
> > enabled implicitly by all its users.
> > 
> 
> Thanks, sorry for giving you the opportunity for finding all these odd
> combinations.
> 
> Are you aware of any projects aiming to catch these through e.g.
> dependency analysis rather than random build testing (and my now growing
> manual checklist)?

I think there is one project that tries to identify impossible constraints
in Kconfig, but that would not have caught cases like this one.

	Arnd