linux-kernel - Re: [PATCH v6 1/2] sparc: fix a building error reported by kbuild

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Dec 2016 22:58:51 +0100
From:   Sam Ravnborg <sam@...nborg.org>
To:     Gonglei <arei.gonglei@...wei.com>
Cc:     linux-kernel@...r.kernel.org, qemu-devel@...gnu.org,
        virtio-dev@...ts.oasis-open.org,
        virtualization@...ts.linux-foundation.org,
        linux-crypto@...r.kernel.org, luonengjun@...wei.com,
        mst@...hat.com, stefanha@...hat.com, weidong.huang@...wei.com,
        wu.wubin@...wei.com, xin.zeng@...el.com,
        claudio.fontana@...wei.com, herbert@...dor.apana.org.au,
        pasic@...ux.vnet.ibm.com, davem@...emloft.net,
        jianjay.zhou@...wei.com, hanweidong@...wei.com,
        arei.gonglei@...mail.com, cornelia.huck@...ibm.com,
        xuquan8@...wei.com, longpeng2@...wei.com, wanzongshun@...wei.com,
        sparclinux@...r.kernel.org
Subject: Re: [PATCH v6 1/2] sparc: fix a building error reported by kbuild

Hi Gonglei.

On Thu, Dec 08, 2016 at 12:37:08PM +0800, Gonglei wrote:
> >> arch/sparc/include/asm/topology_64.h:44:44:
> error: implicit declaration of function 'cpu_data'
> [-Werror=implicit-function-declaration]
> 
>  #define topology_physical_package_id(cpu) (cpu_data(cpu).proc_id)
>                                                ^
> Let's include cpudata.h in topology_64.h.
> 
> Cc: Sam Ravnborg <sam@...nborg.org>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: sparclinux@...r.kernel.org
> Suggested-by: Sam Ravnborg <sam@...nborg.org>
> Signed-off-by: Gonglei <arei.gonglei@...wei.com>
Acked-by: Sam Ravnborg <sam@...nborg.org>

> ---
>  arch/sparc/include/asm/topology_64.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/sparc/include/asm/topology_64.h b/arch/sparc/include/asm/topology_64.h
> index 7b4898a..2255430 100644
> --- a/arch/sparc/include/asm/topology_64.h
> +++ b/arch/sparc/include/asm/topology_64.h
> @@ -4,6 +4,7 @@
>  #ifdef CONFIG_NUMA
>  
>  #include <asm/mmzone.h>
> +#include <asm/cpudata.h>

Nitpick - if you are going to resend this patch, then please
order the two includes in alphabetic order.

For two includes this looks like bikeshedding, but when we add
more having them in a defined arder prevents merge conflicts.
And makes it readable too.

We also sometimes order the includes with the longest lines topmost,
and lines with the ame length are ordered alphabetically.
But this is not seen so often.

	Sam