linux-kernel - Re: [PATCH] proc: mm: export PTE sizes directly in smaps (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1103bf7b-b4a9-3378-7f09-ea67f8bed4a8@sr71.net>
Date:   Fri, 9 Dec 2016 15:10:05 -0800
From:   Dave Hansen <dave@...1.net>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Christoph Hellwig <hch@....de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Dan Williams <dan.j.williams@...el.com>,
        khandual@...ux.vnet.ibm.com, vbabka@...e.cz, linux-mm@...ck.org,
        Linux-Arch <linux-arch@...r.kernel.org>
Subject: Re: [PATCH] proc: mm: export PTE sizes directly in smaps (v3)

On 12/01/2016 06:50 AM, Andy Shevchenko wrote:
>> > +static int size_shift(unsigned long long nr)
>> > +{
>> > +       if (nr < (1ULL<<10))
>> > +               return 0;
>> > +       if (nr < (1ULL<<20))
>> > +               return 10;
>> > +       if (nr < (1ULL<<30))
>> > +               return 20;
>> > +       if (nr < (1ULL<<40))
>> > +               return 30;
>> > +       if (nr < (1ULL<<50))
>> > +               return 40;
>> > +       if (nr < (1ULL<<60))
>> > +               return 50;
>> > +       return 60;
>> > +}
>> > +
> New copy of string_get_size() ?

Not really.  That prints to a buffer, so we'll need to allocate stack
space for a buffer, which we also have to size properly.  We also want
to be consistent with other parts of smaps that mean kB==1024 bytes, so
we want string_get_size()'s STRING_UNITS_10 strings, but
STRING_UNITS_2's divisor.

Also, guaranteeing that we have a power-of-2 'block size' lets us cheat
and do things much faster than using real division.  Not that it
matters, but we could do it thousands of times for a large smaps file.

Being defined locally, this stuff also gets inlined pretty aggressively.

Given all that, I'm not sure I want to modify string_get_size() to do
exactly what we need here.