linux-kernel - Re: [regression ?] kbuild: fix building bzImage with CONFIG_TRIM_UNUSED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1612082235510.1657@knanqh.ubzr>
Date:   Thu, 8 Dec 2016 22:40:21 -0500 (EST)
From:   Nicolas Pitre <nicolas.pitre@...aro.org>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
cc:     Jarod Wilson <jarod@...hat.com>, Michal Marek <mmarek@...e.com>,
        linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [regression ?] kbuild: fix building bzImage with CONFIG_TRIM_UNUSED_KSYMS
 enabled

On Fri, 9 Dec 2016, Sergey Senozhatsky wrote:

> On (12/09/16 11:43), Sergey Senozhatsky wrote:
> > 
> > after 53924022d8a ("kbuild: fix building bzImage withCONFIG_TRIM_UNUSED_KSYMS
> > enabled") all of my build scripts build the kernel without the modules.
> 
> [..]
> > +# For the kernel to actually contain only the needed exported symbols,
> > +# we have to build modules as well to determine what those symbols are.
> > +# (this can be evaluated only once include/config/auto.conf has been included)
> 					^^^^^
> 
> ah, the config. so the patch is wrong.

Furthermore, the export statement exports the variable not its value. 
Even if the value is changed afterwards, referencing the exported 
variable will see the new value.

You can try out this little Makefile to prove it:

FOOBAR := 0
export FOOBAR
FOOBAR := 1
all:
	echo FOOBAR is $$FOOBAR


Nicolas