linux-kernel - Re: [PATCH] Staging: iio: impedance-analyzer: ad5933: fix wrong comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1eda9a06-063e-e865-9032-2883b4d26584@kernel.org>
Date:   Sat, 10 Dec 2016 17:51:07 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Nizam Haider <nizamhaider786@...il.com>, pmeerw@...erw.net
Cc:     lars@...afoo.de, Michael.Hennerich@...log.com, knaack.h@....de,
        gregkh@...uxfoundation.org, linux-iio@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Nizam Haider <nijam.h@....com>
Subject: Re: [PATCH] Staging: iio: impedance-analyzer: ad5933: fix wrong
 comments

On 07/12/16 17:44, Nizam Haider wrote:
> according to datasheet complete control register is of 2 bytes.
> http://www.analog.com/media/en/technical-documentation/data-sheets/AD5933.pdf
> 
> Signed-off-by: Nizam Haider <nijam.h@....com>
Applied to the togreg branch of iio.git - initially pushed out as testing so the
autobuilders can completely ignore this patch ;)

Jonathan
> ---
>  drivers/staging/iio/impedance-analyzer/ad5933.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index 3892a74..f39e03a 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -23,8 +23,8 @@
>  #include <linux/iio/kfifo_buf.h>
>  
>  /* AD5933/AD5934 Registers */
> -#define AD5933_REG_CONTROL_HB		0x80	/* R/W, 2 bytes */
> -#define AD5933_REG_CONTROL_LB		0x81	/* R/W, 2 bytes */
> +#define AD5933_REG_CONTROL_HB		0x80	/* R/W, 1 byte */
> +#define AD5933_REG_CONTROL_LB		0x81	/* R/W, 1 byte */
>  #define AD5933_REG_FREQ_START		0x82	/* R/W, 3 bytes */
>  #define AD5933_REG_FREQ_INC		0x85	/* R/W, 3 bytes */
>  #define AD5933_REG_INC_NUM		0x88	/* R/W, 2 bytes, 9 bit */
>