linux-kernel - Re: [PATCH] scsi/qla2xxx: label endian-ness for many fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1481348968.5946.48.camel@perches.com>
Date:   Fri, 09 Dec 2016 21:49:28 -0800
From:   Joe Perches <joe@...ches.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>, qla2xxx-upstream@...gic.com,
        jejb@...ux.vnet.ibm.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Himanshu.Madhani@...ium.com, Bart.VanAssche@...disk.com
Subject: Re: [PATCH] scsi/qla2xxx: label endian-ness for many fields

On Fri, 2016-12-09 at 22:45 +0200, Michael S. Tsirkin wrote:
> This adds endian-ness labels for lots of qla structs.
> Doing this cuts down number of sparse warnings from ~1700 to ~1400.
> Will help find and resolve some of real issues down the road.
> 
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> 
> ---
> 
> Compile-tested only.
> 
> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
> index 73b12e4..a4d3071 100644
> --- a/drivers/scsi/qla2xxx/qla_def.h
> +++ b/drivers/scsi/qla2xxx/qla_def.h
> @@ -1159,28 +1159,28 @@ typedef struct {
>  	 */
>  	uint8_t  firmware_options[2];
>  
> -	uint16_t frame_payload_size;
> -	uint16_t max_iocb_allocation;
> -	uint16_t execution_throttle;
> +	__le16 frame_payload_size;
> +	__le16 max_iocb_allocation;
> +	__le16 execution_throttle;

Shouldn't all these _not_ have the leading __?
Perhaps the uint8_t uses should be converted to u8 as well.

[etc...]