linux-kernel - Re: [PATCH] drm/nouveau: fix unknown chipset for GTX 1060

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2016 21:44:13 +1000
From:   Ben Skeggs <bskeggs@...hat.com>
To:     Chris Chiu <chiu@...lessm.com>, David Airlie <airlied@...ux.ie>,
        Alexandre Courbot <acourbot@...dia.com>,
        Karol Herbst <nouveau@...olherbst.de>,
        Martin Peres <martin.peres@...e.fr>,
        dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Cc:     linux@...lessm.com
Subject: Re: [PATCH] drm/nouveau: fix unknown chipset for GTX 1060

On 12/12/2016 09:26 PM, Chris Chiu wrote:
> Nouveau driver shows unknown chipset (136000a1) for GTX 1060, so it
> only gives VGA resolution on screen. Use the same chipset as nv134
> then it shows FullHD. This commit copies fields from nv134_chipset
> to nv136_chipset for GTX 1060.
I have one of these sitting on my desk, but won't be merging support for
it until it's been confirmed that no additional changes are required vs
GP104.  We've been bitten by just making these kind of blind assumptions
before.

Thanks,
Ben.

> 
> Signed-off-by: Chris Chiu <chiu@...lessm.com>
> ---
>  drivers/gpu/drm/nouveau/nvkm/engine/device/base.c | 29 +++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c b/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c
> index 7218a06..7c6eece 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/base.c
> @@ -2209,6 +2209,34 @@ nv134_chipset = {
>  	.fifo = gp100_fifo_new,
>  };
>  
> +static const struct nvkm_device_chip
> +nv136_chipset = {
> +	.name = "GP104",
> +	.bar = gf100_bar_new,
> +	.bios = nvkm_bios_new,
> +	.bus = gf100_bus_new,
> +	.devinit = gm200_devinit_new,
> +	.fb = gp104_fb_new,
> +	.fuse = gm107_fuse_new,
> +	.gpio = gk104_gpio_new,
> +	.i2c = gm200_i2c_new,
> +	.ibus = gm200_ibus_new,
> +	.imem = nv50_instmem_new,
> +	.ltc = gp100_ltc_new,
> +	.mc = gp100_mc_new,
> +	.mmu = gf100_mmu_new,
> +	.pci = gp100_pci_new,
> +	.timer = gk20a_timer_new,
> +	.top = gk104_top_new,
> +	.ce[0] = gp104_ce_new,
> +	.ce[1] = gp104_ce_new,
> +	.ce[2] = gp104_ce_new,
> +	.ce[3] = gp104_ce_new,
> +	.disp = gp104_disp_new,
> +	.dma = gf119_dma_new,
> +	.fifo = gp100_fifo_new,
> +};
> +
>  static int
>  nvkm_device_event_ctor(struct nvkm_object *object, void *data, u32 size,
>  		       struct nvkm_notify *notify)
> @@ -2644,6 +2672,7 @@ nvkm_device_ctor(const struct nvkm_device_func *func,
>  		case 0x12b: device->chip = &nv12b_chipset; break;
>  		case 0x130: device->chip = &nv130_chipset; break;
>  		case 0x134: device->chip = &nv134_chipset; break;
> +		case 0x136: device->chip = &nv136_chipset; break;
>  		default:
>  			nvdev_error(device, "unknown chipset (%08x)\n", boot0);
>  			goto done;
> 



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)