linux-kernel - Re: [PATCH v2] KVM: hyperv: fix locking of struct kvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2016 14:27:47 +0300
From:   Roman Kagan <rkagan@...tuozzo.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
CC:     <linux-kernel@...r.kernel.org>, <kvm@...r.kernel.org>,
        <dvyukov@...gle.com>
Subject: Re: [PATCH v2] KVM: hyperv: fix locking of struct kvm_hv fields

On Mon, Dec 12, 2016 at 10:12:53AM +0100, Paolo Bonzini wrote:
> Introduce a new mutex to avoid an AB-BA deadlock between kvm->lock and
> vcpu->mutex.  Protect accesses in kvm_hv_setup_tsc_page too, as suggested
> by Roman.
> 
> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
> Cc: Roman Kagan <rkagan@...tuozzo.com>
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
> ---
>  Documentation/virtual/kvm/locking.txt |  8 ++++++--
>  arch/x86/include/asm/kvm_host.h       |  1 +
>  arch/x86/kvm/hyperv.c                 | 24 +++++++++++++++---------
>  arch/x86/kvm/x86.c                    |  1 +
>  4 files changed, 23 insertions(+), 11 deletions(-)

Reviewed-by: Roman Kagan <rkagan@...tuozzo.com>