linux-kernel - Re: [V1] mtd: devices: docg3:- Handle return value of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2016 16:19:24 -0200
From:   Fabio Estevam <festevam@...il.com>
To:     Marek Vasut <marek.vasut@...il.com>
Cc:     Arvind Yadav <arvind.yadav.cs@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Richard Weinberger <richard@....at>,
        Cyrille Pitchen <cyrille.pitchen@...el.com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [V1] mtd: devices: docg3:- Handle return value of devm_ioremap.

On Sun, Dec 11, 2016 at 5:15 PM, Marek Vasut <marek.vasut@...il.com> wrote:

>>       ret = -ENOMEM;
>> +     base = devm_ioremap(dev, ress->start, DOC_IOSPACE_SIZE);
>> +     if (!base)
>> +             return ret;
>
> I think return -ENOMEM right away won't hurt here. Also, dev_err()
> explaining the failure would be nice to add.

There is no need to add dev_err() message as the mm core will complain
loudly if devm_ioremap() fails.