linux-kernel - Re: [PATCH 1/2] mm/thp/pagecache: Only withdraw page table after a successful deposit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Dec 2016 00:01:18 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:     akpm@...ux-foundation.org,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        mpe@...erman.id.au, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mm/thp/pagecache: Only withdraw page table after a
 successful deposit

On Mon, Dec 12, 2016 at 10:04:27PM +0530, Aneesh Kumar K.V wrote:
> The current code wrongly called withdraw in the error path. But we
> haven't depoisted the page table yet in the only error path in that
> function. So for now remove that withdraw completely. If we take
> that "out:" branch, we should have vmf->prealloc_pte already pointing
> to the allocated page table.
> 
> Fixes: "mm: THP page cache support for ppc64"
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>

Reported-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

-- 
 Kirill A. Shutemov