linux-kernel - Re: [PATCH 1/2] crypto: asymmetric

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.20.1612130852380.23354@namei.org>
Date:   Tue, 13 Dec 2016 08:53:11 +1100 (AEDT)
From:   James Morris <jmorris@...ei.org>
To:     David Howells <dhowells@...hat.com>
cc:     Pan Bian <bianpan2016@....com>, keyrings@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-kernel-module@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH 1/2] crypto: asymmetric_keys: set error code on failure

On Mon, 12 Dec 2016, David Howells wrote:

> From: Pan Bian <bianpan2016@....com>
> 
> In function public_key_verify_signature(), returns variable ret on
> error paths. When the call to kmalloc() fails, the value of ret is 0,
> and it is not set to an errno before returning. This patch fixes the
> bug.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188891
> 
> Signed-off-by: Pan Bian <bianpan2016@....com>
> Signed-off-by: David Howells <dhowells@...hat.com>
> ---

These crypto patches should probably go via Herbert's tree.


> 
>  crypto/asymmetric_keys/public_key.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/crypto/asymmetric_keys/public_key.c b/crypto/asymmetric_keys/public_key.c
> index fd76b5fc3b3a..d3a989e718f5 100644
> --- a/crypto/asymmetric_keys/public_key.c
> +++ b/crypto/asymmetric_keys/public_key.c
> @@ -121,6 +121,7 @@ int public_key_verify_signature(const struct public_key *pkey,
>  	if (ret)
>  		goto error_free_req;
>  
> +	ret = -ENOMEM;
>  	outlen = crypto_akcipher_maxsize(tfm);
>  	output = kmalloc(outlen, GFP_KERNEL);
>  	if (!output)
> 

-- 
James Morris
<jmorris@...ei.org>