linux-kernel - Re: [PATCH RFC] clk: wm831x: fix usleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161213091637.GM1867@localhost.localdomain>
Date:   Tue, 13 Dec 2016 09:16:37 +0000
From:   Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:     Nicholas Mc Guire <hofrat@...dl.org>
CC:     Michael Turquette <mturquette@...libre.com>,
        Mark Brown <broonie@...nsource.wolfsonmicro.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        <patches@...nsource.wolfsonmicro.com>, <linux-clk@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC] clk: wm831x: fix usleep_range with bad range

On Mon, Dec 12, 2016 at 08:40:09AM +0100, Nicholas Mc Guire wrote:
> The delay here is not in atomic context and does not seem critical with
> respect to precision, but usleep_range(min,max) with min==max results in 
> giving the timer subsystem no room to optimize uncritical delays. Fix 
> this by setting the range to 2000,3000 us.
> 
> Fixes: commit f05259a6ffa4 ("clk: wm831x: Add initial WM831x clock driver")
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> ---

Yeah looks fine waiting longer for the FLL to lock won't cause
any issues.

Acked-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>

Thanks,
Charles