linux-kernel - Re: [PATCH 1/2] ARM: nommu: allow enabling REMAP_VECTORS_TO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <584FBCAC.5010700@arm.com>
Date:   Tue, 13 Dec 2016 09:17:32 +0000
From:   Vladimir Murzin <vladimir.murzin@....com>
To:     Afzal Mohammed <afzal.mohd.ma@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Arnd Bergmann <arnd@...db.de>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ARM: nommu: allow enabling REMAP_VECTORS_TO_RAM

On 11/12/16 13:11, Afzal Mohammed wrote:
> REMAP_VECTORS_TO_RAM depends on DRAM_BASE, but since DRAM_BASE is a
> hex, REMAP_VECTORS_TO_RAM could never get enabled. Also depending on
> DRAM_BASE is redundant as whenever REMAP_VECTORS_TO_RAM makes itself
> available to Kconfig, DRAM_BASE also is available as the Kconfig gets
> sourced on !MMU.
> 
> Signed-off-by: Afzal Mohammed <afzal.mohd.ma@...il.com>
> ---
>  arch/arm/Kconfig-nommu | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/Kconfig-nommu b/arch/arm/Kconfig-nommu
> index aed66d5df7f1..b7576349528c 100644
> --- a/arch/arm/Kconfig-nommu
> +++ b/arch/arm/Kconfig-nommu
> @@ -34,8 +34,7 @@ config PROCESSOR_ID
>  	  used instead of the auto-probing which utilizes the register.
>  
>  config REMAP_VECTORS_TO_RAM
> -	bool 'Install vectors to the beginning of RAM' if DRAM_BASE
> -	depends on DRAM_BASE
> +	bool 'Install vectors to the beginning of RAM'
>  	help
>  	  The kernel needs to change the hardware exception vectors.
>  	  In nommu mode, the hardware exception vectors are normally
> 

I have similar change in my local tree, so FWIW:

Reviewed-by: Vladimir Murzin <vladimir.murzin@....com>