linux-kernel - Re: [PATCH 2/7] blk-mq: abstract out blk_mq_dispatch_rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71656abd-f737-6548-9e07-a899e33fcd9f@sandisk.com>
Date:   Tue, 13 Dec 2016 10:29:41 +0100
From:   Bart Van Assche <bart.vanassche@...disk.com>
To:     Ritesh Harjani <riteshh@...eaurora.org>, Jens Axboe <axboe@...com>,
        <axboe@...nel.dk>, <linux-block@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     <paolo.valente@...aro.org>, <osandov@...com>
Subject: Re: [PATCH 2/7] blk-mq: abstract out blk_mq_dispatch_rq_list() helper

On 12/13/2016 10:18 AM, Ritesh Harjani wrote:
> On 12/9/2016 1:43 AM, Jens Axboe wrote:
>> +    if (!list_empty_careful(&hctx->dispatch)) {
>> +        spin_lock(&hctx->lock);
>> +        if (!list_empty(&hctx->dispatch))
> list_splice_init already checks for list_empty. So this may be
> redundant. Please check.

Hello Ritesh,

I think the list_empty() check is on purpose and is intended as a 
performance optimization.

Bart.