linux-kernel - Re: [PATCH] cifs: Fix smbencrypt() to stop pointing a scatterlist at the stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74b22139-4583-5bab-3916-4a32db81803e@cogentembedded.com>
Date:   Tue, 13 Dec 2016 14:40:17 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Andy Lutomirski <luto@...nel.org>, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, sfrench@...ba.org
Cc:     Eric Biggers <ebiggers3@...il.com>, linux-crypto@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Stephan Mueller <smueller@...onox.de>,
        linux-cifs@...r.kernel.org
Subject: Re: [PATCH] cifs: Fix smbencrypt() to stop pointing a scatterlist at
 the stack

Hello!

On 12/12/2016 11:54 PM, Andy Lutomirski wrote:

> smbencrypt() points a scatterlist to the stack, which is breaks if

    s/is//.

> CONFIG_VMAP_STACK=y.
>
> Fix it by switching to crypto_cipher_encrypt_one().  The new code
> should be considerably faster as an added benefit.
>
> This code is nearly identical to some code that Eric Biggers
> suggested.
>
> Cc: stable@...r.kernel.org # 4.9 only
> Reported-by: Eric Biggers <ebiggers3@...il.com>
> Signed-off-by: Andy Lutomirski <luto@...nel.org>
[...]

MBR, Sergei