lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Dec 2016 12:31:44 +0000 From: Mark Rutland <mark.rutland@....com> To: Laura Abbott <labbott@...hat.com> Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>, Will Deacon <will.deacon@....com>, Catalin Marinas <catalin.marinas@....com>, Andrey Ryabinin <aryabinin@...tuozzo.com>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>, Marek Szyprowski <m.szyprowski@...sung.com>, Joonsoo Kim <iamjoonsoo.kim@....com>, linux-arm-kernel@...ts.infradead.org, Alexander Potapenko <glider@...gle.com>, Dmitry Vyukov <dvyukov@...gle.com>, kasan-dev@...glegroups.com Subject: Re: [PATCHv5 09/11] mm/kasan: Switch to using __pa_symbol and lm_alias On Tue, Dec 06, 2016 at 03:50:55PM -0800, Laura Abbott wrote: > > __pa_symbol is the correct API to find the physical address of symbols. > Switch to it to allow for debugging APIs to work correctly. Other > functions such as p*d_populate may call __pa internally. Ensure that the > address passed is in the linear region by calling lm_alias. > > Reviewed-by: Mark Rutland <mark.rutland@....com> > Tested-by: Mark Rutland <mark.rutland@....com> > Signed-off-by: Laura Abbott <labbott@...hat.com> > --- > v5: Add missing lm_alias call > --- > mm/kasan/kasan_init.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/mm/kasan/kasan_init.c b/mm/kasan/kasan_init.c > index 3f9a41c..922f459 100644 > --- a/mm/kasan/kasan_init.c > +++ b/mm/kasan/kasan_init.c > @@ -16,6 +16,7 @@ > #include <linux/kernel.h> > #include <linux/memblock.h> > #include <linux/pfn.h> > +#include <linux/mm.h> Nit: include ordering. Regardless, my tags above still stand! Thanks, Mark.
Powered by blists - more mailing lists