linux-kernel - Re: [PATCH v2 3/4] printk/btrfs: Handle more message headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 13 Dec 2016 15:26:02 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Joe Perches <joe@...ches.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jason Wessel <jason.wessel@...driver.com>
Subject: Re: [PATCH v2 3/4] printk/btrfs: Handle more message headers

On Tue, Dec 13, 2016 at 02:52:47PM +0100, Petr Mladek wrote:
> Here is the proposed fix for the warning:
> 
> 
> From 5b5a8f7ff4f2d5c33316e600a29d45314ac47a16 Mon Sep 17 00:00:00 2001
> From: Petr Mladek <pmladek@...e.com>
> Date: Tue, 13 Dec 2016 13:12:56 +0100
> Subject: [PATCH] btrfs: Better handle btrfs_printk() defaults
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> The commit 262c5e86fec7cfd ("printk/btrfs: handle more message headers")
> triggers:
> 
>     warning: ‘ratelimit’ may be used uninitialized in this function
> 
> with gcc (4.1.2) and probably many other versions. The code actually
> is correct but a bit twisted. Let's make it more straightforward
> and set the default values at the beginning.
> 
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Petr Mladek <pmladek@...e.com>

Acked-by: David Sterba <dsterba@...e.com>