linux-kernel - Re: [PATCH] selftest: sync: improve assert() failure message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a0af9595-4322-7f72-8d14-d6bd7abcf0f2@kernel.org>
Date:   Tue, 13 Dec 2016 07:33:47 -0700
From:   Shuah Khan <shuah@...nel.org>
To:     Gustavo Padovan <gustavo@...ovan.org>
Cc:     linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        emilio.lopez@...labora.co.uk,
        Gustavo Padovan <gustavo.padovan@...labora.com>,
        Shuah Khan <shuah@...nel.org>,
        Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] selftest: sync: improve assert() failure message

On 12/13/2016 06:48 AM, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@...labora.com>
> 
> Print "ERROR" on all messages instead of using the not well defined terms
> like "BAD".
> 
> Signed-off-by: Gustavo Padovan <gustavo.padovan@...labora.com>
> ---
>  tools/testing/selftests/sync/synctest.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/sync/synctest.h b/tools/testing/selftests/sync/synctest.h
> index 4e0e59f..e7d1d57 100644
> --- a/tools/testing/selftests/sync/synctest.h
> +++ b/tools/testing/selftests/sync/synctest.h
> @@ -32,7 +32,7 @@
>  
>  #define ASSERT(cond, msg) do { \
>  	if (!(cond)) { \
> -		printf("[BAD]\t%s", (msg)); \
> +		printf("[ERROR]\t%s", (msg)); \
>  		return 1; \
>  	} \
>  } while (0)
> 

Thanks, Applied to linux-kselftest next for 4.10-rc1

-- Shuah