linux-kernel - Re: [PATCH 7/7] blk-mq-sched: allow setting of default IO scheduler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6e98baa-7b11-8c5c-74b9-5d40bccc97a2@fb.com>
Date:   Tue, 13 Dec 2016 08:06:53 -0700
From:   Jens Axboe <axboe@...com>
To:     Bart Van Assche <bart.vanassche@...disk.com>, <axboe@...nel.dk>,
        <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <paolo.valente@...aro.org>, <osandov@...com>
Subject: Re: [PATCH 7/7] blk-mq-sched: allow setting of default IO scheduler

On 12/13/2016 03:13 AM, Bart Van Assche wrote:
> On 12/08/2016 09:13 PM, Jens Axboe wrote:
>> +config DEFAULT_MQ_IOSCHED
>> +	string
>> +	default "mq-deadline" if DEFAULT_MQ_DEADLINE
>> +	default "none" if DEFAULT_MQ_NONE
>> +
>>  endmenu
>>
>> +config MQ_IOSCHED_ONLY_SQ
>> +	bool "Enable blk-mq IO scheduler only for single queue devices"
>> +	default y
>> +	help
>> +	  Say Y here, if you only want to enable IO scheduling on block
>> +	  devices that have a single queue registered.
>> +
>>  endif
> 
> Hello Jens,
> 
> Shouln't the MQ_IOSCHED_ONLY_SQ entry be placed before "endmenu" such 
> that it is displayed in the I/O scheduler menu instead of the block menu?

Good catch, yes it should. I'll move it.

-- 
Jens Axboe