lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <25312310.aENfjP0Zdi@wuerfel>
Date:   Tue, 13 Dec 2016 22:37:58 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Max Bires <jbires@...gle.com>
Cc:     gregkh@...uxfoundation.org, josh@...htriplett.org,
        linux-kernel@...r.kernel.org
Subject: Re: /drivers/char/Kconfig Bug Kernel Patch

On Tuesday, December 13, 2016 1:30:39 PM CET Max Bires wrote:
> While trying to turn off the port device in defconfig, I ran into a bug
> caused by the fact that the Kconfig for port didn't have a string after the
> bool declaration. I fixed this in the attached patch (though I figure the
> description might need tuning up). Let me know if there's anything else I
> need to do.

The change looks reasonable, however there are a few things to improve
to get the patch applied:

- clarify that the current behavior is not a bug, but was done intentionally.
  Making the option user-visible would help avoid a potential attack vector
  and make the kernel smaller, both of which are useful.

- remove the "Change-id" line from the submission, it has no meaning in 
  an upstream kernel

- send the patch inline rather than as an attachment, this is usually done
  with git-send-email.

	Arnd

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ